Angular 4 ExpressionChangedAfterItHasBeenCheckedError
The article Everything you need to know about the ExpressionChangedAfterItHasBeenCheckedError
error explains this behavior in great details
Cause
Your problem is very similar to this one but instead of updating parent property through a service you're updating it through synchronous event broadcasting. Here is the quote from the linked answer:
During digest cycle Angular performs certain operations on child directives. One of such operations is updating inputs and calling ngOnInit lifecycle hook on child directives/components. What's important is that these operations are performed in strict order:
- Update inputs
- Call ngOnInit
So in your case Angular updated input binding allItems
on child component, then called onInit
on child component which caused an update to allItems
of parent component. Now you have data inconsistency. Parent component has one value while the child another. If Angular continues synchronizing changes you'll get an infinite loop. That's why during next change detection cycle Angular detected that allItems
was changed and thrown an error.
Solution
It seems that this is an application design flaw as you're updating details
from both parent and child component. If it's not, then you can solve the problem by emitting the event asynchronously like this:
export class ChildComponent implements OnInit {
@Output() notify: EventEmitter<any> = new EventEmitter(true);
^^^^^^-------------
But you have to be very careful. If you use any other hook like ngAfterViewChecked
that is being called on every digest cycle, you'll end up in cyclic dependency!