Are there more entangled states or non-entangled ones?

I'm assuming that you have a finite-dimensional base Hilbert space $\mathcal H_0$ and that you're building your full Hilbert space as $\mathcal H=\mathcal H_0\otimes \mathcal H_0$. In these conditions, the set of separable states has measure zero.

(It gets a bit more complicated if you have $\mathcal H_0^{\otimes 4}$ and you're allowed to split it any way you want among those two factors, and the answer is negative if you're allowed to look for any tensor-product structure in your space, as you can always take one factor along your given $|\psi⟩$.)

Consider, then, a given basis $\{|n⟩:n=1,\ldots,N\}$ for $\mathcal H_0$, which means that any arbitrary state $|\psi⟩\in\mathcal H$ can be written as $$ |\psi⟩=\sum_{n,m} \psi_{nm}|n⟩\otimes|m⟩. $$ If, in particular, $|\psi⟩$ can be written as a tensor product $|\psi⟩=|u⟩\otimes|v⟩$, then you have $$ |\psi⟩ =\left(\sum_n u_n |n⟩\right)\left(\sum_m v_m |m⟩\right) =\sum_{n,m} u_nv_m |n⟩\otimes|m⟩; $$ that is, the coefficient matrix $\psi_{nm}$ has the form $\psi_{nm}=u_n v_m$. This means that this matrix has rank one, which then means that it must have determinant equal to zero. Since the determinant is a continuous polynomial function $\det\colon \mathbb{C}^{N\times N}\to\mathbb C$, its zero set has Borel measure zero inside $\mathbb{C}^{N\times N}$, and therefore correspondingly inside $\mathcal H$.

This means, finally, that if you choose a random vector $|\psi⟩\in\mathcal H$ using a probability measure that is absolutely continuous with respect to the canonical Borel measure on $\mathcal H\cong\mathbb C^{N\times N}$, then it is almost certainly entangled. As an added bonus from exactly the same argument, such a vector will actually (almost certainly) have a full Schmidt rank.

A bit more intuitively, what this argument is saying is that separable states form a very thin manifold inside the full Hilbert space, and this is caught quite well by the spirit of zeldredge's answer. In particular, to describe an arbitrary separable state, you need $2N-1$ complex parameters ($N$ each for the components of $|u⟩$ and $|v⟩$, minus a shared normalization), so roughly speaking the separable states will form a submanifold of dimension $2N-1$. However, this is embedded inside a much bigger manifold $\mathcal H$ of dimension $N^2$, which requires many more components to describe, so for $N$ bigger than two the separable states are a very thin slice indeed.

No, in fact, "most states" are entangled. (This is meant to be a heuristic; I freely admit this is probably a sticky thing to get into formally as far as randomly picking a state.) My intuition/reason for saying this is that there exist approximation methods which work by restricting themselves to a low-entanglement subspace, such as Matrix Product States (MPS) or Projected Entangled Pair State (PEPS) which can be used to efficiently represent the ground states and dynamics of certain Hamiltonians.

Here's another, more concrete example. Suppose we have a string of qubits. The product states can all be specified with by storing two numbers per qubit (the Bloch angles or the $\left| 0 \right\rangle$ and $\left| 1 \right\rangle$ amplitudes). Therefore for $n$ qubits, we can store $2n$ numbers which capture any product state. However, the full Hilbert space has $2^{n}$ states, which means a general (non-product) state requires specification by $2^n$ different complex numbers. Obviously there are infinite numbers of each since the amplitudes are continuous, but I think it should be clear that the latter case admits many more states, especially if you discretize the space.

The reason why entanglement is a resource is not that entangled states are rare; rather it's that we want to restrict entanglement to be solely between a few systems of interest, whereas most states rapidly entangle with their environment.

I know from this talk by M Horodecki that entangled states are more abundant than separable states. Also see this paper on how separable states form a set of measure zero in pure state space.

As for your argument, I think it can also be seen this way.

$|\psi\rangle = |\psi_1\rangle \otimes|\psi_2\rangle$ can be viewed as a constraint on the structure of the state. For an entangled state there is no such constraint on the structure, therefore one might expect more such states than separable states.

One more argument can be that the reduced density matrix of a party from an entangled state is a mixed state. Now, there are more mixed states than pure states.

However, I would advise caution against trusting such arguments too much.