Changing QGIS plugin's icon, why doesn't it change in the menu/toolbar?
In QGIS 3, one needs to do
pyrcc5 -o resources.py resources.qrc
Your plugin icon was converted to a byte array and saved in resources.py
So if you want to change this icon you have to compile your resources again:
pyrcc4 -o resources.py resources.qrc