Determining the probability of outcomes in a measurement

Let me rephrase what your teacher did. They first defined an operator $\hat{O}$ given by the matrix you have. They then noticed that the operator has two eigenvectors with eigenvalues $+1$ and $-1$, given by the two vectors that you have. Notice that these eigenvectors are orthonormal.

They then interpreted the two eigenvectors as two states of a quantum system, one corresponding to "alive" and the other one to "dead". Then they supposed that you have a system which is in a specific linear combination of these eigenvectors, that is their wavefunction is the $\Phi$ you have.

They then applied the following two axioms of quantum mechanics, things which we believe are rules of nature and cannot be derived from anything else:

• The value of the measurement of an observable (operator) is one of its eigenvalues; the system then "collapses" to the corresponding eigenvector.
• The probability of obtaining a certain eigenvalue is given by the modulus squared of the coefficient of the orthonormal eigenvector corresponding to the eigenvalue in the expansion of the wavefunction.

Your wavefunction is already expanded in terms of orthonormal eigenvectors of $\hat{O}$. By the first axiom, a measurement of $\hat{O}$ can give either $+1$ ("alive") or $-1$ ("dead"). Before the measurement, the wavefunction is given by $\Phi$. Say the measurement yields $+1$. After the measurement, the wavefunction of the system is given by $\Phi'=\varphi_{alive}$. The wavefunction has "collapsed".

By the second axiom, the probability of getting $+1$ is given by $|1/\sqrt{2}|^2=1/2=50\%$ and is the same as the probability of getting $-1$.

In particular, the measurement of an operator is not given by applying the operator to the wavefunction. This works only if the system is in a state which is an eigenvector of the operator. In this case the system has a definite value for that particular operator (which can be for instance, position or momentum). Otherwise the system does not have a definite value for that operator, and when you measure it, you get different outcomes with different probabilities.

There seems to be some confusion here. The act of observation (which collapses the superposition to an eigenstate of $\hat O$) is profoundly different from operating on the state with $\hat O$ which doesn't collapse the state but, rather, returns a different superposition of eigenstates.

For example:

$$\hat O \Phi = \frac{1}{\sqrt{2}}\phi_{alive} - \frac{1}{\sqrt{2}}\phi_{dead} \ne \Phi$$

To get the probability that your state $\Phi$ after measurement (opening the box) collapsed into the eigenstate $\varphi_{alive}$ of the $\hat{O}$ operator ($\hat{O}$ is the operator that corresponds to the observable of 'aliveness') is given by $\left|\left < \varphi_{alive} | \, \Phi\right >\right|^2$. Analogously $\left|\left < \varphi_{dead} | \, \Phi\right >\right|^2$ is the probability of collapsing the state into $\varphi_{dead}$. The fancy $\left <a|b \right >$ notation is the standard scalar product.