Difference between concat and push?
According to the MDN document say that:
push()
method: adds one or more elements to the end of an array and returns the new length of the array.
const count = ['pigs', 'goats'].push('cows');
console.log(count); // expected output: 3
concat()
method is used to merge two or more arrays. This method does not change the existing arrays but instead returns a new array
console.log(['a'].concat(['b']));// expected output: Array ["a", "b"]
And combined with the final Array#reduce
's parameter is the array initialize [])
, which means that you want to return an array result.
==> So that's the reason why in case that you use concat
working well.
Refactor code
- If you still want to use
Array#reduce
andArray#push
const even = (number) => number%2 === 0;
const result = [1, 2, 3, 4].reduce(function name(acc, curr) {
if(even(curr)) acc.push(curr); // Just add one more item instead of return
return acc;
}, []);
console.log(result);
- The simpler way is to use
Array#filter
const even = (number) => number%2 === 0;
console.log([1, 2, 3, 4].filter(even));
The push()
adds elements to the end of an array and returns the new length of the array. Thus your return here is invalid.
The concat()
method is used to merge arrays. Concat does not change the existing arrays, but instead returns a new array.
Better to filter, if you want a NEW array like so:
var arr = [1, 2, 3, 4];
var filtered = arr.filter(function(element, index, array) {
return (index % 2 === 0);
});
Note that assumes the array arr is complete with no gaps - all even indexed values. If you need each individual, use the element
instead of index
var arr = [1, 2, 3, 4];
var filtered = arr.filter(function(element, index, array) {
return (element% 2 === 0);
});
https://dev.to/uilicious/javascript-array-push-is-945x-faster-than-array-concat-1oki Concat is 945x slower than push only because it has to create a new array.
acc
should not be an array. Look at the documentation. It can be one, but..
It makes no sense at all to reduce
an array to an array. What you want is filter
. I mean, reduce
using an array as the accumulator and concat
ing each element to it technically does work, but it is just not the right approach.
var res = [1, 2, 3, 4].filter(even);
console.log(res);
function even(number) {
return (number % 2 === 0);
}