Do the Taylor series of $\sin x$ and $\cos x$ depend on the identity $\sin^2 x + \cos^2 x =1$?
Nice proof! To address your question,
Do Taylor's series of those functions depend on this identity? Because if they do, the proof will be circular.
You are right to be worried about circularity! However, which concepts or theorems depend on which others is a matter of certain flexibility. Often, we take one thing to be the definition of a concept, and then have to prove the other properties as theorems -- but we could alternately have used some other property as a definition, and then the original definition would have to be a theorem.
Specific to your case, I have seen definitions of $\sin$ and $\cos$ where we start by defining $\sin$ using arclength, then we define $\cos x$ to satisfy $\cos^2 x + \sin^2 x = 1$. If we take this approach, certainly, there is nothing to prove. However, this is not the only possible approach! It is also common to define $\sin$ and $\cos$ using their Taylor series. Under this approach, you have given a very nice proof that $\sin^2 x + \cos^2 x = 1$. Your proof could also be valid if we define $\sin$ and $\cos$ to be a basis of functions satisfying $f''(x) = -f(x)$.
In summary, it depends on what you define $\sin$ and $\cos$ to be; however, your proof is not necessarily circular. And it is a nice example of deriving a result about some functions from their Taylor series.
No, they do not depend on the Pythagoren identity. Using the differential equations that define $\sin$ and $\cos$
- $\cos(0) = 1$
- $\sin(0) = 0$
- $\cos' = -\sin$
- $\sin' = \cos$
it's very easy to show that $\forall x \in \mathbb{R}\cos(x) = \sum_{i = 0}^\infty \frac{(-1)^ix^{2i}}{(2x)!}$ and $\forall x \in \mathbb{R}\sin(x) = \sum_{i = 0}^\infty \frac{(-1)^ix^{2i + 1}}{(2x + 1)!}$.