How do I run a code formatter over my source without modifying git history?
You can make git blame
ignoring certain commits, which do only mass reformatting etc.:
Create a file .git-blame-ignore-revs
like:
# Format commit 1 SHA:
1234af5.....
# Format commit 2 SHA:
2e4ac56.....
Then do
git config blame.ignoreRevsFile .git-blame-ignore-revs
, so that you don't have to use the --ignore-revs-file
option every time with git blame
.
Upvote https://github.com/github/feedback/discussions/5033 to get that feature into github's web blame viewer.
What you are trying to do is impossible. You cannot, at some point in time, change a line of code, and yet have git report that the most recent change to that line of code is something that happened before that point in time.
I suppose a source control tool could support the idea of an "unimportant change", where you mark a commit as cosmetic and then history analysis would skip over that commit. I'm not sure how the tool would verify that the change really was cosmetic, and without some form of tool enforcement the feature would assuredly be misused resulting in bug introductions potentially being hidden in "unimportant" commits. But really the reasons I think it's a bad idea are academic here - the bottom line is, git doesn't have such a feature. (Nor can I think of any source control tool that does.)
You can change the formatting going forward. You can preserve the visibility of past changes. You can avoid editing history. But you cannot do all three at the same time, so you're going to have to decide which one to sacrifice.
There are actually a couple down-sides to the history rewrite, by the way. You mentioned processing time, so let's look at that first:
As you've noted, the straightforward way to do this with filter-branch
would be very time consuming. There are things you can do to speed it up (like giving it a ramdisk for its working tree), but it's a tree-filter
and it involves processing of each version of each file.
If you did some pre-processing, you could be somewhat more efficient. For example, you might be able to preprocess every BLOB
in the database and create a mapping (where a TREE
contains BLOB
X, replace it with BLOB
Y), and then use an index-filter
to perform the substitutions. This would avoid all the checkout and add operations, and it would avoid repeatedly re-formatting the same code files. So that saves a lot of I/O. But it's a non-trivial thing to set up, and still might be time consuming.
(It's possible to write a more specialized tool based on this same principle, but AFAIK nobody has written one. There is precedent that more specialized tools can be faster than filter-branch
...)
Even if you come to a solution that will run fast enough, bear in mind that the history rewrite will disturb all of your refs. Like any history rewrite, it will be necessary for all users of the repo to update their clones - and for something this sweeping, the way I recommend to do that is, throw the clones out before you start the rewrite and re-clone afterward.
That also means if you have anything that depends on commit ID's, that will also be broken. (That could include build infrastructure, or release documentation, etc.; depending on your project's practices.)
So, a history rewrite is a pretty drastic solution. And on the other hand, it also seems drastic to suppose that formatting the code is impossible simply because it wasn't done from day 1. So my advice:
Do the reformatting in a new commit. If you need to use git blame
, and it points you to the commit where reformatting occurred, then follow up by running git blame
again on the reformat commit's parent.
Yeah, it sucks. For a while. But a given piece of history tends to become less important as it ages, so from there you just let the problem gradually diminish into the past.
git blame -w -M
is supposed to ignore whitespace and moved code changes, so you just need to reformat your code and remember to use those options when looking for who to blame!
https://coderwall.com/p/x8xbnq/git-don-t-blame-people-for-changing-whitespaces-or-moving-code