In polar coordinates, can r be negative?
I think that the graph of $r = a \sin( 2 \theta)$ should have two petals only. It's not wrong to draw four petals if you define negative $r$, as $(r,\theta) = (-r,\theta + \pi)$ if $r<0$. The problem with this definition is that polar coordinates are now no longer a bijection. The same point in cartesian coordinates will have two different polar coordinates. This is not a problem if you only want to draw graphs, but it is a serious problem in more advanced applications of Calculus. For instance you cannot use this coordinate change in a double integral if the transformation is not bijective (the point $r=0$ is not a problem because it is a set with measure $0$).
I think everyone will agree that $r = 2 \cos(\theta)$ is one circle. If you allow negative $r$, you will draw each point of the circle twice. This is not a problem if you're just graphing, but if you want the arc length you can get twice the correct answer.
Now let's return to $r = a \sin(2\theta)$ and see the corresponding cartesian equation.
$r = a \sin(2\theta) = 2 a \cos\theta \sin\theta$.
Multiplying each side by $r^2$ we get
$r^3 = 2 a ( r \cos \theta ) ( r \sin \theta)$,
which in cartesian coordinates is
$( x^2 + y^2 )^{\frac32} = 2 a x y$.
Since the left-hand side is positive, you should only draw points if $2a x y \geq 0$, so only in first and third quadrant if $a>0$. If we square both sides than we get
$( x^2 + y^2 )^{3} = 4 a^2 x^2 y^2$
and this graph has indeed four petals, but we introduced extraneous (or spurious) solutions, like squaring $x=1$ to obtain $x^2=1$ which now allows $x=-1$ as a solution. If we start with this last equation and try to derive the corresponding polar coordinates we get
$r^6 = 4 a^2 (r \cos\theta)^2 (r \sin \theta) ^2$.
$r^2 = a^2 ( 2 \cos \theta \sin \theta)^2 = a^2 ( \sin(2\theta) )^2$
So
$r = a \sqrt{\sin^2(2 \theta)} = a |\sin(2\theta)|$.
And $r = a |\sin(2\theta)|$ has indeed four petals, but $|\sin(2\theta)| \neq \sin(2\theta)$ if $\sin(2\theta)<0$, which happens in the second and fourth quadrant. So I would draw $r = a \sin(2\theta)$ with two petals only and would use $r = a |\sin(2\theta)|$ if I wanted the curve with four petals. I wouldn't say it's wrong to draw points with negative $r$ if you know what you're doing and you're not using these points to evaluate lengths and areas.
I agree with you. Saying $r$ when given as a function of $\theta$ must be positive is, in my opinion, as bad as saying that if $y=f(x)$ then $y$ must be positive. It certainly takes away from the beauty and symmetry of polar graphs. I'm actually wondering what he thinks the graph of $r=\cos\theta$ looks like.
I hope you've misunderstood your teacher, because his statement is not true. Though I wouldn't be surprised if this is some crazy new 'common core' approach.
To be honest, you should just use the definitions your teacher gives. It is less hassle and if you later want to argue a point which depends on those definitions then you have a leg to stand on. That doesn't mean you shouldn't press the issue and see if you can't get a reason from em or try to convert em, but in the meantime E is still the one grading your paper.
The question of which one is "right" is, unfortunately, probably meaningless. Both have good justifications and unless you can find some internal inconsistency with using one or the other, they both seem reasonable.