If I buy golden gun for a hero, is it only for that skin or for every skin?

Golden weapon skins are separate from hero skins meaning that yes, the golden weapon can be used with any hero skin.