improving C circular buffer efficiency
If you can make your buffer size a power-of-2, then the check against zero can be replaced with unconditional bit-masking. On most processors, this should be faster.
This may not be seem elegant but is efficient. Accessing structure elements through the pointer is taking up a lot of instructions. Why not remove the structure altogether and make buffer
and writeIndex
as global variables? This will considerably decrease the size of your readn
and write
functions.
I tried in gcc and here is the output with and without the structure
With Structure
_write:
pushl %ebp
movl %esp, %ebp
movl 8(%ebp), %ecx
movl 8(%ebp), %eax
movl 16(%eax), %edx
movl 12(%ebp), %eax
movl %eax, (%ecx,%edx,4)
movl 8(%ebp), %eax
incl 16(%eax)
movl 8(%ebp), %eax
cmpl $3, 16(%eax)
jne L1
movl 8(%ebp), %eax
movl $0, 16(%eax)
L1:
popl %ebp
ret
Without Structure. ie Making buffer
and writeIndex
as global
_write:
pushl %ebp
movl %esp, %ebp
movl _writeIndex, %edx
movl 8(%ebp), %eax
movl %eax, _buff(,%edx,4)
incl _writeIndex
cmpl $3, _writeIndex
jne L1
movl $0, _writeIndex
L1:
popl %ebp
ret
Keeping track of the start and the end of the circular buffer with pointers, is likely a bit faster than array indexing, since the address will computed in runtime in case of the latter. Try to replace readIndex and writeIndex with float*
instead. The code would then be
*buffer->writeIndex = value;
buffer->writeIndex++;
if(buffer->writeIndex == buffer + BUFF_SIZE)
buffer->writeIndex=buffer->buff;
buffer + BUFF_SIZE
will still be a constant expression and the compiler will translate that to a fixed address at compile time.
As "Oli Charlesworth" suggested - you'd be able to simplify things if your buffer size is a power of 2. I'd like to write the read/write function bodies, so that the intent is more clear.
#define BUFF_SIZE (4U)
#define BUFF_SIZE_MASK (BUFF_SIZE-1U)
struct buffer {
float buff[BUFF_SIZE];
unsigned writeIndex;
};
void write(struct buffer *buffer, float value) {
buffer->buff[(++buffer->writeIndex) & BUFF_SIZE_MASK] = value;
}
float readn(struct buffer *buffer, unsigned Xn){
return buffer->buff[(buffer->writeIndex - Xn) & BUFF_SIZE_MASK];
}
Some explanations. Note that there's no branching (if
) at all. We don't limit the array index to the array bounds, instead we're AND-ing it with the mask.