JavaScript variables declare outside or inside loop?
There is absolutely no difference in meaning or performance, in JavaScript or ActionScript.
var
is a directive for the parser, and not a command executed at run-time. If a particular identifier has been declared var
once or more anywhere in a function body(*), then all use of that identifier in the block will be referring to the local variable. It makes no difference whether value
is declared to be var
inside the loop, outside the loop, or both.
Consequently you should write whichever you find most readable. I disagree with Crockford that putting all the vars at the top of a function is always the best thing. For the case where a variable is used temporarily in a section of code, it's better to declare var
in that section, so the section stands alone and can be copy-pasted. Otherwise, copy-paste a few lines of code to a new function during refactoring, without separately picking out and moving the associated var
, and you've got yourself an accidental global.
In particular:
for (var i; i<100; i++)
do something;
for (var i; i<100; i++)
do something else;
Crockford will recommend you remove the second var
(or remove both var
s and do var i;
above), and jslint will whinge at you for this. But IMO it's more maintainable to keep both var
s, keeping all the related code together, instead of having an extra, easily-forgotten bit of code at the top of the function.
Personally I tend to declare as var
the first assignment of a variable in an independent section of code, whether or not there's another separate usage of the same variable name in some other part of the same function. For me, having to declare var
at all is an undesirable JS wart (it would have been better to have variables default to local); I don't see it as my duty to duplicate the limitations of [an old revision of] ANSI C in JavaScript as well.
(*: other than in nested function bodies)
In theory it shouldn't make any difference in JavaScript, since the language does not have block scope, but only function scope.
I'm not sure about the performance argument, but Douglas Crockford still recommends that the var
statements should be the first statements in the function body. Quoting from Code Conventions for the JavaScript Programming Language:
JavaScript does not have block scope, so defining variables in blocks can confuse programmers who are experienced with other C family languages. Define all variables at the top of the function.
I think he has a point, as you can see in the following example. Declaring the variables at the top of the function should not confuse readers into thinking that the variable i
is held in the scope of the for
loop block:
function myFunction() {
var i; // the scope of the variables is very clear
for (i = 0; i < 10; i++) {
// ...
}
}