string formatting a sql query in sqlite3
SQL needs strings in VALUES
to be quoted. Integers and floats do not need to be quoted.
In the commented output below, notice that the SQL VALUES
contains unquoted strings for "Fillet-o-Fish" and "Best fish in the sea":
sql = "INSERT INTO mcdonalds_menu VALUES(%d, %s, %f, %s, %d)".format(ids[num], names[num], price[num], descriptions[num], calories[num])
# INSERT INTO mcdonalds_menu VALUES(2, Fillet-o-Fish, 2.250000, Best fish in the sea, 450)
Adding some escaped quotes around your string values produces valid SQL:
sql = "INSERT INTO mcdonalds_menu VALUES(%d, \"%s\", %f, \"%s\", %d)" % (ids[num],names[num], price[num], descriptions[num], calories[num])
# INSERT INTO mcdonalds_menu VALUES(2, "Fillet-o-Fish", 2.250000, "Best fish in the sea", 450)
All the other answers relying on python's string manipulation are insecure and might not correctly escape quotes in your strings.
The best way to do it, as suggested in sqlite3
documentation, is to use the DB-API’s parameter substitution. In your example, it would look like this:
menu_items = [(1, 'McFlurry', 1.5, 'Delicious sweet icecream', 220),
(2, 'Fillet-o-Fish', 2.25, 'Best fish in the sea', 450),
(3, 'McCafe', 0.99, 'Freshly brewed Colombian coffee', 75)
]
c.executemany('INSERT INTO mcdonalds_menu VALUES (?,?,?,?,?)', menu_items)
With Python 3.6+ you can simplify this quoting mess with f strings. For example:
c.execute(f"select sql from sqlite_master where type='table' and name='{table_name}';")
for r in c.fetchall():
print(r)
In this snippet, the important thing to note is f
preceding the sql string. This allows one to pass in variables surrounded by curly braces, in my example: '{table_name}'