what do process do you follow for code check in? code example
Example 1: code review meeting
We are code reviewing to find out whether any bug
can be found earlier before testing starts
General purpose of Code Review Meeting:
- Early Bug Detection
- Finding better solutions
- Mentoring Juniors / Knowledge Transfer
- Team Cohesion
- Compliance to Standards
What we are looking for:
- whether the test steps in feature file covers
the requirement of user story and acceptance criteria
- refactoring codes (remove poor design and duplicate coding)
- structure
- the complexity of logic ==> simplicity is the ultimate sophistication
- readability for others
Example 2: what do you do in code review meeting
We are code reviewing to find out whether any bug
can be found earlier before testing starts
General purpose of Code Review Meeting:
- Early Bug Detection
- Finding better solutions
- Mentoring Juniors / Knowledge Transfer
- Team Cohesion
- Compliance to Standards
What we are looking for:
- whether the test steps in feature file covers
the requirement of user story and acceptance criteria
- refactoring codes (remove poor design and duplicate coding)
- structure
- the complexity of logic
- readability for others