Where should signal handlers live in a django project?
I actually like to make them classmethods of the model itself. That keeps everything within one class, and means you don't have to worry about importing anything.
This was added to the documentation when Django 1.7 was released:
Strictly speaking, signal handling and registration code can live anywhere you like, although it’s recommended to avoid the application’s root module and its models module to minimize side-effects of importing code.
In practice, signal handlers are usually defined in a signals submodule of the application they relate to. Signal receivers are connected in the ready() method of your application configuration class. If you’re using the receiver() decorator, simply import the signals submodule inside ready().
Changed in Django 1.7: Since ready() didn’t exist in previous versions of Django, signal registration usually happened in the models module.
Best practice is to define your handlers in handlers.py in a signals submodule, e.g. a file that looks like:
yourapp/signals/handlers.py:
from django.db.models.signals import pre_save
from django.dispatch import receiver
from myapp.models import MyModel
@receiver(pre_save, sender=MyModel)
def my_handler(sender, **kwargs):
pass
The best place to register your signal handler is then in the AppConfig of the app that defines it, using the ready() method. This will look like this:
yourapp/apps.py:
from django.apps import AppConfig
class TasksConfig(AppConfig):
name = 'tasks'
verbose_name = "Tasks"
def ready(self):
import yourproject.yourapp.signals.handlers #noqa
Make sure you're loading your AppConfig by specifying it either directly in your settings.py's INSTALLED_APPS, or in the __init__
of your app. See see the ready() documentation for more information.
Note: If you're providing signals for other apps to listen too as well, put them in the __init__
in your signals module, e.g. a file that looks like:
yourapp/signals/_init_.py
import django.dispatch
task_generate_pre_save = django.dispatch.Signal(providing_args=["task"])
Another app can then listen to your signal by importing and registering it, e.g. from yourapp.signals import task_generate_pre_save
. Separating your signals from your handlers keeps things clean.
Instructions for Django 1.6:
If you're still stuck on Django 1.6 or lower, then you'd do the same thing (define your handlers in yourapp/signals/handlers.py) but rather than using AppConfig, you would load the handlers via the _init_.py of your app, e.g. something like:
yourapp/_init_.py
import signals
This isn't as nice as using the ready() method because it often causes circular import issues.
I've only just come across this, and as my signals are not model-related I thought I'd add my solution.
I am logging various data around log in / log out, and needed to hook into django.contrib.auth.signals
.
I have put the signal handlers into a signals.py
file, and then imported signals from the __init__.py
module file, as I believe this is called as soon as the app starts up (testing with a print
statement suggests that it's called even before the settings file is read.)
# /project/__init__.py
import signals
and in signals.py
# /project/signals.py
from django.contrib.auth.signals import user_logged_in
def on_logged_in(sender, user, request, **kwargs):
print 'User logged in as: \'{0}\''.format(user)
user_logged_in.connect(on_logged_in)
I'm pretty new to Django (/python) so am open to anyone telling me that this is a terrible idea!