Why componentWillMount should not be used?
UPDATE: componentWillMount will soon be deprecated.
To cite @Dan Abramov
In future versions of React we expect that componentWillMount will fire more than once in some cases, so you should use componentDidMount for network requests.
Read more here.
UPDATE - may / 2018
There is a new feature for react in a working progress called async rendering.
As of react v16.3.2
these methods are not "safe" to use:
- componentWillMount
- componentWillReceiveProps
- componentWillUpdate
you can read more about it in the docs.
As a general rule don't use componentWillMount
at all (if you use the es6 class
syntax). use the constructor
method instead.
This life-cycle method is good for a sync state initialization.componentDidMount
in the other hand is good for async state manipulation.
Why?
Well, when you do an async request in the constructor
/ componentWillMount
you do it before render
gets called, by the time the async operation has finished the render
method most probably already finished and no point to set the "initial state" at this stage is it?.
I'm not sure this is your case here, but most of the cases that developers wants to initiate state asynchronously in componentWillMount
is to avoid a second render
call. but you can't avoid it can you, like mentioned above, render
will fire anyway before the async operation will finish.
So, the best time to call an async operation is after a render
has called and the component mounted (you could mount null
or an empty <div/>
) and then fetch your data, set the state and make it re-render respectively.
componentDidMount
is the best place to put calls to fetch data, for two reasons:
Using
componentDidMount
makes it clear that data won’t be loaded until after the initial render. You need to setup initial state properly, so you don’t getundefined
state that causes errors.If you need to render your app on the server,
componentWillMount
will be called twice(on the server and again on the client), which is probably not what you want. Putting the data loading code incomponentDidMount
will ensure that data is only fetched from the client. Generally, you should not add side effects tocomponentWillMount
.