Why doesn't my MongoDB $or query work?

Simply because $or should be a top level operator in your query, like this:

db.collection.find({
        "$or": [
            {
                "metadata.text": { "$regex": ".*hello.*" }
            },
            {
                "metadata.text": { "$regex": ".*world.*" }
            }
        ]
})